Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic NaN-safe mode switching #181

Open
jrevels opened this issue Dec 26, 2016 · 3 comments
Open

dynamic NaN-safe mode switching #181

jrevels opened this issue Dec 26, 2016 · 3 comments

Comments

@jrevels
Copy link
Member

jrevels commented Dec 26, 2016

Follow-up issue to #179. From my comment there:

In a future PR, we could add AbstractConfig constructors like GradientConfig(x, Chunk{N}, NaNSafe{true}). The generated dual numbers would then contain partials of type Partials{N,T,true}, which would dispatch to the NaN-safe versions of methods. Downstream modules could then support passing that option through their APIs (or simply setting it to a reasonable default for themselves internally).
@cossio
Copy link
Contributor

cossio commented Oct 15, 2018

This would be very nice to have!

@sharanry sharanry mentioned this issue Sep 10, 2020
Open
15 tasks
@taylormcd
Copy link

Is it possible we could use Preferences.jl to enable/disable NaN-safe mode now? See JuliaLang/Pkg.jl#458. I think that would effectively solve this long-standing issue.

@devmotion devmotion mentioned this issue Apr 19, 2021
Merged
@KristofferC KristofferC mentioned this issue Jul 28, 2021
Merged
@devmotion
Copy link
Member

NaN-safe mode switching via the Preferences.jl system was added in #539.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@devmotion @jrevels @cossio @taylormcd