-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the preference system for nan safe mode #539
Conversation
Closes #181 I think |
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
==========================================
- Coverage 84.90% 84.76% -0.14%
==========================================
Files 9 9
Lines 828 827 -1
==========================================
- Hits 703 701 -2
- Misses 125 126 +1
Continue to review full report at Codecov.
|
What's holding back this PR? It would be great if switching to |
Nothing really. Someone to review it perhaps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My knowledge about Preferences is only based on its README, but according to this it looks good to me. Seems to match the instructions in https://github.com/JuliaPackaging/Preferences.jl#conditional-loading.
How does one |
As a user you would use |
julia> using ForwardDiff, Preferences
julia> set_preferences!(ForwardDiff, "nansafe_mode" => true) Ah, thanks! |
No description provided.