Skip to content

Conversation

@giordano
Copy link
Contributor

@giordano giordano commented Nov 6, 2025

I believe the documentation as written now is quite ambiguous.

@fingolfin fingolfin added Type: Documentation Skip Changelog Allows the CHANGELOG.md check to pass without edit to the file. labels Nov 7, 2025
@mortenpi
Copy link
Member

mortenpi commented Nov 7, 2025

I don't mind this, but personally I never follow the URLs, so implying that you have to fill those two values in can be annoying -- I really just want the key values. Could we easily accommodate both cases?

@fingolfin
Copy link
Collaborator

@mortenpi I am confused by your comment (I might be parsing it wrong): which URLs do you mean that you "never follow", and how does this relate to the change @giordano is proposing"?

Are you suggesting something DocumenterTools.genkeys() for keys generated for out-of-repo deployment is fine? If so, what's the context?

Copy link
Collaborator

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me, but I'll delay merging to see if @mortenpi clarifies what he meant

@mortenpi
Copy link
Member

which URLs do you mean that you "never follow"

The only difference between calling genkeys with or without arguments is the URLs it generates in the output.

image

It's meant to just let you click on the URL to go to the right page, but I never actually use them myself. So I am not convinced it's good to imply here that you seemingly have to fill those arguments out, since it's a bunch of annoying typing for the user which they likely do not care about.

But I don't have a strong opinion -- if we feel that this is an improvement, we can merge this.

@fingolfin
Copy link
Collaborator

Thank you for the explanation @mortenpi now I understand what you meant.

So yeah, without any arguments, it prints URLs like https://github.com/$USER/$REPO/settings/keys with literatlly $USER in there. Not sure what is misleading about that...

@giordano your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog Allows the CHANGELOG.md check to pass without edit to the file. Type: Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants