Skip to content

Add pocl upstream as a CI #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 25, 2025
Merged

Add pocl upstream as a CI #298

merged 3 commits into from
Apr 25, 2025

Conversation

vchuravy
Copy link
Member

No description provided.

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.61%. Comparing base (66f408c) to head (5b8b346).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   73.12%   73.61%   +0.48%     
==========================================
  Files          12       12              
  Lines         614      614              
==========================================
+ Hits          449      452       +3     
+ Misses        165      162       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maleadt maleadt mentioned this pull request Apr 1, 2025
@maleadt
Copy link
Member

maleadt commented Apr 15, 2025

Tried building the experimental PR here, as well as switching to static linking against LLVM 20, however:

In file included from /home/runner/.julia/artifacts/0c8a7d47e3327c7247a3a4c60fb6df027918c6f9/include/LLVMSPIRVLib/LLVMSPIRVLib.h:44,
                 from /home/runner/work/OpenCL.jl/OpenCL.jl/pocl/lib/CL/pocl_llvm_spirv.cc:67:
/home/runner/.julia/artifacts/0c8a7d47e3327c7247a3a4c60fb6df027918c6f9/include/LLVMSPIRVLib/LLVMSPIRVOpts.h:42:10: fatal error: llvm/ADT/Optional.h: No such file or directory
   42 | #include <llvm/ADT/Optional.h>
      |          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.

... so I guess mixing LLVM 20 with LLVM-SPIRV translator 16 does not work, and we'll have to link that one statically as well.

@maleadt maleadt marked this pull request as draft April 15, 2025 16:24
@maleadt
Copy link
Member

maleadt commented Apr 15, 2025

Yay, just a single segfault. Probably because of having switched to LLVM 20, which is still kinda experimental with PoCL.

@maleadt
Copy link
Member

maleadt commented Apr 15, 2025

Huh, the same segfault. Guess I'll have to reduce that.

@maleadt
Copy link
Member

maleadt commented Apr 25, 2025

Awesome, this passes tests :-)

@maleadt maleadt marked this pull request as ready for review April 25, 2025 16:53
@maleadt maleadt merged commit df89e61 into master Apr 25, 2025
5 of 7 checks passed
@maleadt maleadt deleted the vc/pocl_upstream branch April 25, 2025 16:54
This was referenced May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants