Skip to content

Commit

Permalink
Avoid method redefinition in plotting extensions, to allow precompila…
Browse files Browse the repository at this point in the history 
…iton
  • Loading branch information
@brenhinkeller
brenhinkeller committed Jun 10, 2024
1 parent 0ce069b commit 68fac78
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "Isoplot"
uuid = "5adc30d5-9ddf-423c-bb15-ece697bec3ab"
authors = ["C. Brenhin Keller <[email protected]>"]
version = "0.3.3"
version = "0.3.4"

[deps]
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
Expand Down
17 changes: 11 additions & 6 deletions src/generic_plotting.jl
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
function concordiacurve() end
# Establish our plotting functions with dummy methods that will never be used
# (using zero-arg methods for this isn't sufficient since concordialine
# and concordialine! may have real zero-arg methods)
struct NotUsed end

function concordiacurve!() end
function concordiacurve(x::NotUsed) end

function concordialine() end
function concordiacurve!(x::NotUsed) end

function concordialine!() end
function concordialine(x::NotUsed) end

function rankorder() end
function concordialine!(x::NotUsed) end

function rankorder!() end
function rankorder(x::NotUsed) end

function rankorder!(x::NotUsed) end

2 comments on commit 68fac78

@brenhinkeller
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/108820

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.3.4 -m "<description of version>" 68fac7841f9d97d7faa57875a3ae0d5406f5cc3c
git push origin v0.3.4

Please sign in to comment.