Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bool branch interpretation #102

Merged
merged 2 commits into from
Sep 15, 2021
Merged

fix bool branch interpretation #102

merged 2 commits into from
Sep 15, 2021

Conversation

aminnj
Copy link
Member

@aminnj aminnj commented Sep 15, 2021

We needed a specialized case to interpret boolean branches as Vector{Bool} instead of BitVector. I factored out the solution and unit test from #95 .

before

💥🚗

after

julia> using UnROOT

julia> f = UnROOT.samplefile("NanoAODv5_sample.root");

julia> f["Events/L1_ZeroBias"]
1000-element LazyBranch{Bool, UnROOT.Nojagg, Vector{Bool}}:
 1
 1
 1
 1
 1
 1
 1
 
 1
 1
 1
 1
 1
 1
 1

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #102 (a282676) into master (4c2c991) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a282676 differs from pull request most recent head 773cb42. Consider uploading reports for the commit 773cb42 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   88.17%   88.19%   +0.01%     
==========================================
  Files          11       11              
  Lines        1328     1330       +2     
==========================================
+ Hits         1171     1173       +2     
  Misses        157      157              
Impacted Files Coverage Δ
src/root.jl 90.99% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c2c991...773cb42. Read the comment docs.

src/root.jl Outdated Show resolved Hide resolved
Co-authored-by: Jerry Ling <[email protected]>
@Moelf Moelf merged commit 47d2ec9 into JuliaHEP:master Sep 15, 2021
aminnj added a commit that referenced this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants