Changed sum(.) to reduce(., init=0) in storagesize functions #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 17361585816Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
meggart
approved these changes
Jun 13, 2025
meggart
approved these changes
Aug 25, 2025
asinghvi17
added a commit
that referenced
this pull request
Aug 31, 2025
This commit adds tests that demonstrate the issue reported in #197 where calling zinfo() on an empty array (with no initialized chunks) fails with an ArgumentError on DirectoryStore. The tests will fail on master but pass after PR #198 is merged. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
3 tasks
asinghvi17
approved these changes
Aug 31, 2025
Merged
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
asinghvi17
reviewed
Aug 31, 2025
meggart
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197
Changed storagesize implementation for DirectoryStore so it doesn't break when no chunks are initialized by replacing sum(.) with reduce(., init=0). Also changed DictStore implementation to match even though it was technically not broken before.