Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around #532 #533

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Work around #532 #533

merged 1 commit into from
Mar 12, 2025

Conversation

christiangnrd
Copy link
Contributor

This seems to be an issue with running concurrent tests when the spinner is enabled. This PR deactivates the spinner. This closes #532 and makes the test output somewhat cleaner.

@JamesWrigley
Copy link
Member

Unofficial LGTM! I'll try looking into this later, ReTest.jl is supposed to work with multiple threads.

@christiangnrd
Copy link
Contributor Author

christiangnrd commented Mar 10, 2025

Unofficial LGTM! I'll try looking into this later, ReTest.jl is supposed to work with multiple threads.

Sounds good thank you! I think this should stay even when ReTest gets fixed since the Clang.jl test suite is quite verbose and the spinner makes the output quite hard to read through.

I also just opened JuliaTesting/ReTest.jl#61.

@Gnimuc Gnimuc requested a review from JamesWrigley March 12, 2025 01:34
@Gnimuc
Copy link
Member

Gnimuc commented Mar 12, 2025

@JamesWrigley feel free to merge if it get fixed.

Copy link
Member

@JamesWrigley JamesWrigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger that, I'll merge this now so as to fix the tests.

@JamesWrigley JamesWrigley merged commit ae9cbc2 into JuliaInterop:master Mar 12, 2025
16 of 18 checks passed
@christiangnrd christiangnrd deleted the patch-1 branch March 12, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test suite segfault when run with more than 1 thread.
3 participants