Skip to content

accept Ptr{Int8} in unsafe_string and unsafe_wrap #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2016
Merged

accept Ptr{Int8} in unsafe_string and unsafe_wrap #245

merged 1 commit into from
Jul 15, 2016

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Jul 1, 2016

This fixes unsafe_string and unsafe_wrap so that they accept both Ptr{Int8} and Ptr{UInt8}, like the functions in Base.

This should supersede #244. (Sorry for the duplication, @r9y9; I prepared this patch yesterday but didn't have a chance to push it until now.)

@stevengj stevengj mentioned this pull request Jul 1, 2016
Closed
@stevengj
Copy link
Member Author

stevengj commented Jul 1, 2016

Travis failure on nightly seems unrelated: the @test_throws ArgumentError tryparse(Int32, "0", 1) test is failing.

@yuyichao
Copy link
Contributor

yuyichao commented Jul 1, 2016

Ref #240 (comment)

@ararslan
Copy link
Member

ararslan commented Jul 2, 2016

It would be awesome if we could tag a new version once this is merged.

@ararslan ararslan mentioned this pull request Jul 2, 2016
Merged
@stevengj stevengj mentioned this pull request Jul 8, 2016
Closed
@stevengj
Copy link
Member Author

stevengj commented Jul 8, 2016

Pushed a tweak to the tests to restart Travis, hopefully the unrelated tryparse problem is gone now?

@stevengj
Copy link
Member Author

stevengj commented Jul 8, 2016

@yuyichao, is there any progress towards fixing the tryparse error on nightly?

@yuyichao
Copy link
Contributor

yuyichao commented Jul 8, 2016

@quinnj

@stevengj stevengj mentioned this pull request Jul 8, 2016
Merged
@stevengj stevengj force-pushed the unsafe_string_ptr branch from 7a2c831 to cd12ef9 Compare July 10, 2016 19:30
@sglyon
Copy link

sglyon commented Jul 11, 2016

Is this particular PR causing the tryparse failure, or is it really unrelated. From @stevengj comment, it seems to be unrelated.

@stevengj
Copy link
Member Author

@spencerlyon2, it is unrelated — the error was fixed in JuliaLang/julia#17333. Once that PR has migrated into the nightly builds and the tests are re-run by doing a push on this PR, the failures should go away.

@stevengj stevengj force-pushed the unsafe_string_ptr branch from cd12ef9 to d4a37a5 Compare July 11, 2016 12:36
@stevengj
Copy link
Member Author

stevengj commented Jul 11, 2016 •
edited
Loading

the new failure should be fixed by #249

@stevengj stevengj closed this Jul 12, 2016
@stevengj stevengj reopened this Jul 12, 2016
@stevengj stevengj force-pushed the unsafe_string_ptr branch from d4a37a5 to 5aeafeb Compare July 12, 2016 18:24
@tkelman
Copy link
Contributor

tkelman commented Jul 14, 2016

is this gtg?

@stevengj
Copy link
Member Author

Yes.

@stevengj stevengj merged commit 0f13317 into master Jul 15, 2016
@stevengj stevengj deleted the unsafe_string_ptr branch July 15, 2016 13:04
@sglyon
Copy link

sglyon commented Jul 18, 2016

Can we tag now that this has been merged?

@tkelman
Copy link
Contributor

tkelman commented Jul 18, 2016

Yeah, probably.

@sglyon sglyon mentioned this pull request Jul 18, 2016
Merged
dpsanders pushed a commit to dpsanders/Compat.jl that referenced this pull request Feb 1, 2017
@stevengj @dpsanders
accept Ptr{Int8} in unsafe_string and unsafe_wrap (closes JuliaLang#244…
4c11e3a 
…) (JuliaLang#245)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stevengj @yuyichao @ararslan @sglyon @tkelman