Backports release v1.12 #1237
Merged
Backports release v1.12 #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #1237 +/- ##
================================================
+ Coverage 91.90% 91.93% +0.03%
================================================
Files 34 34
Lines 15385 15381 -4
================================================
+ Hits 14139 14141 +2
+ Misses 1246 1240 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reopens JuliaLang/julia#55481 One argument there was that packages may wish to define custom eigenvalue algorithms. I'm unsure if this is common, but in principle, we may provide an internal method `eigen(A, alg)` that packages extend, and users may call the method with `alg` as a keyword argument. Fixes #1208 --------- Co-authored-by: Viral B. Shah <[email protected]>
|
I may not have time for this, but this should be merged once tests pass, and then bumped on the release-1.12 branch over at julialang. |
This ensures that our LazyLibrary code, (which makes one allocation) does not fail these tests. Some of these `@allocations` checks had already included warm-up code, this simply expands that to the rest that I could find.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mulindirection #1215algto a keyword argument in symmetric eigen #1214