Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't zero out destination in generic_matvecmul #1242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Mar 17, 2025

Currently, mul!(c::AbstractVector, A::AbstractMatrix, b::AbstractVector) is computed (schematically) as

c .= 0 # zero of the correct type
for y in eachcol(A .* permutedims(b))
    c .+= y
end

Filling c with zeros at the beginning is unnecessary. We may instead start by storing first(eachcol(A .* permutedims(b))) directly in c, followed by a loop over the other columns. This reduces one loop over c, although the difference in performance is minimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants