Add postCreateCommand to the feature #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
reviewed
Jun 26, 2023
eitsupi
requested changes
Jun 26, 2023
eitsupi
reviewed
Jun 29, 2023
|
@JuliaLang @davidanthoff Could you take a look at this? (Unfortunately I cannot merge this.) |
Soft ping to the maintainers—can we get this in? |
davidanthoff
approved these changes
Aug 27, 2023
|
Do we need to do something so that this is picked up? Tag or something? Or is it enough to have this on |
I assume this was released because you ran the CI manually. Thanks! |
|
Yep, I think so! |
|
Thanks! Yes, can confirm it's been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
Adds a
postcreate.jlscript (taken from https://github.com/julia-vscode/julia-devcontainer) to the container on install and sets is as thepostCreateCommandof the feature.I'm using
/usr/local/julia-devcontainer-features/postcreate.jlfor the location of the script inside the container, but I don't know the conventions here, and there might very well be a better path.