Skip to content

Commit

Permalink
Comment out url and fix typo in stackwalk.c (#56131)
Browse files Browse the repository at this point in the history
Introduced in #55623
  • Loading branch information
Zentrik authored Oct 13, 2024
1 parent 1713f79 commit 80e60c8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/stackwalk.c
Original file line number Diff line number Diff line change
Expand Up @@ -933,7 +933,7 @@ extern bt_context_t *jl_to_bt_context(void *sigctx) JL_NOTSAFEPOINT;
int jl_simulate_longjmp(jl_jmp_buf mctx, bt_context_t *c) JL_NOTSAFEPOINT
{
#if (defined(_COMPILER_ASAN_ENABLED_) || defined(_COMPILER_TSAN_ENABLED_))
https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/hwasan/hwasan_interceptors.cpp
// https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/hwasan/hwasan_interceptors.cpp
return 0;
#elif defined(_OS_WINDOWS_)
_JUMP_BUFFER* _ctx = (_JUMP_BUFFER*)mctx;
Expand Down Expand Up @@ -1049,7 +1049,7 @@ int jl_simulate_longjmp(jl_jmp_buf mctx, bt_context_t *c) JL_NOTSAFEPOINT
mc->regs[28] = (*_ctx)[9];
mc->regs[29] = (*_ctx)[10]; // aka fp
mc->regs[30] = (*_ctx)[11]; // aka lr
// Yes, they did skip 12 why writing the code originally; and, no, I do not know why.
// Yes, they did skip 12 when writing the code originally; and, no, I do not know why.
mc->sp = (*_ctx)[13];
mcfp->vregs[7] = (*_ctx)[14]; // aka d8
mcfp->vregs[8] = (*_ctx)[15]; // aka d9
Expand Down

2 comments on commit 80e60c8

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Please sign in to comment.