Anj/docldlt #13030
Merged
Anj/docldlt #13030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| doc""" | ||
| ldltfact(A) -> F | ||
|
|
||
| Compute an `LDLt` factorization `F` of a `SymTridiagonal` matrix `A` such that `A=L*Diagonal(d)*L'` where `L` is a unit lower triangular matrix and `d` is a vector. The main use of an `LDLt` factorization `F=ldltfact(A)` is to solving the linear system of equations `Ax=b` with `F\b`. |
There was a problem hiding this comment.
Would be better to be consistent on whether LDLt is quoted (see the other doc string in helpdb.jl)
There was a problem hiding this comment.
Thanks. I'll fix that.
kshyatt
added
docs
|
Hold on with the comments. I messed up with the build sequence for the docs. Maybe, when you wake up tomorrow, I've managed to contribute to the documentation without breaking anything. |
andreasnoack
force-pushed
the
anj/docldlt
branch
from
0be7c4d to
4c62c1c
Compare
andreasnoack
force-pushed
the
anj/docldlt
branch
from
4c62c1c to
b22d6f7
Compare
|
lgtm. So is there no diagonal-D (modified Cholesky) edit: ref JuliaLang/LinearAlgebra.jl#203 for adding a generic julia implementation |
|
Yes. That is correct. |
|
backport candidate here? |
|
Yes |
|
backported in #13072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ldltfactdocumentation was wrong. The other changes ended up here after a rebase so I added them with a new commit. Are they okay to include?