Skip to content

make sure parseint base can be any Integer type #17335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2016
Merged

make sure parseint base can be any Integer type #17335

merged 1 commit into from
Jul 8, 2016

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Jul 8, 2016

While working on #17333, I noticed that, although parse and tryparse accept base::Integer, only Int actually works because parseint_preamble requires an Int. This fixes it.

@stevengj
Copy link
Member Author

stevengj commented Jul 8, 2016

Note that Julia 0.4 has the same problem, but in a slightly different place in the code due to #17078, so this PR can't be backported directly. I'm not sure it's worth the trouble to make the corresponding fix in 0.4 since no one seems to have run into this before.

@tkelman
Copy link
Contributor

tkelman commented Jul 8, 2016

LGTM

@stevengj stevengj merged commit 5c93b3a into JuliaLang:master Jul 8, 2016
@stevengj stevengj deleted the tryparse_base branch July 8, 2016 19:29
@quinnj
Copy link
Member

quinnj commented Jul 8, 2016

+1

mfasi pushed a commit to mfasi/julia that referenced this pull request Sep 5, 2016
@stevengj @mfasi
make sure parseint base can be any Integer type (JuliaLang#17335)
c766ce4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevengj @tkelman @quinnj