Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regular expressions in Test tests #57085

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

mhauru
Copy link
Contributor

@mhauru mhauru commented Jan 17, 2025

Several tests for Test.jl weren't really testing for much because | characters were taken to be or operators in the regular expressions.

Copy link
Contributor

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as https://github.com/JuliaLang/julia/pull/56260/files#diff-b44eebf66a97ac0a68b21f779e752f2f3b59063151bb90e92802c49eb58ebd4b, didn't realise there were more tests like that. Thanks for the catch!

@giordano giordano added testsystem The unit testing framework and Test stdlib merge me PR is reviewed. Merge when all tests are passing labels Jan 17, 2025
@inkydragon inkydragon merged commit fa9478b into JuliaLang:master Jan 18, 2025
7 checks passed
@inkydragon inkydragon removed the merge me PR is reviewed. Merge when all tests are passing label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testsystem The unit testing framework and Test stdlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants