Default to 1 interactive thread #57087
Open
+143
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
commented
Jan 17, 2025
This comment was marked as resolved.
This comment was marked as resolved.
IanButterworth
force-pushed
the
ib/default_interactive_thread
branch
2 times, most recently
from
bd7417f to
ac4361b
Compare
IanButterworth
added
needs docs
IanButterworth
commented
Jan 18, 2025
Comment on lines
-537
to
-550
| function test_thread_range() | ||
| a = zeros(Int, threadpoolsize()) | ||
| @threads for i in 1:threadid() | ||
| a[i] = 1 | ||
| end | ||
| for i in 1:threadid() | ||
| @test a[i] == 1 | ||
| end | ||
| for i in (threadid() + 1):threadpoolsize() | ||
| @test a[i] == 0 | ||
| end | ||
| end | ||
| test_thread_range() | ||
|
|
There was a problem hiding this comment.
I couldn't figure out what this test is actually testing, given the test script always runs from thread 1
IanButterworth
force-pushed
the
ib/default_interactive_thread
branch
5 times, most recently
from
0eaf9c1 to
4b52062
Compare
IanButterworth
force-pushed
the
ib/default_interactive_thread
branch
2 times, most recently
from
339c71f to
50a8cce
Compare
IanButterworth
commented
Jan 20, 2025
| @@ -614,7 +614,7 @@ Start some other operations that use `f(x)`: | |||
| julia> g(x) = f(x) | |||
| g (generic function with 1 method) | |||
|
|
|||
| julia> t = Threads.@spawn f(wait()); yield(); | |||
| julia> t = @async f(wait()); yield(); | |||
There was a problem hiding this comment.
These were changed to @spawn in #55315 but I think they make sense as @async otherwise more orchestration is needed when multiple threads are available to make the examples work as expected.
IanButterworth
commented
Jan 20, 2025
Comment on lines
+603
to
+608
| // single threaded mode | ||
| // Note: with -t1,1 a signal 10 occurs in task_scanner | ||
| jl_options.nthreadpools = 1; | ||
| jl_options.nthreads = 1; | ||
| int16_t ntpp[] = {jl_options.nthreads}; | ||
| jl_options.nthreads_per_pool = ntpp; |
There was a problem hiding this comment.
Could the signal 10 be related to/fixed by #56477 ?
fix test thread indexing make threads_exec work being called from :interactive and :default pools add tests for threaded construct default pools etc.
I believe these make more sense as async than spawn, otherwise more orchestration is needed in the example. Were changed to spawn in JuliaLang#55315
IanButterworth
force-pushed
the
ib/default_interactive_thread
branch
from
fc001e6 to
920085e
Compare
IanButterworth
removed
needs news
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43672
So:
default== 1 default, 1 interactive-t1== 1 default, 1 interactive-t1,0== 1 default, 0 interactiveetc.
Motivations
Todo
:interactivethreadpool, and that a bare@spawnor@threadswill schedule in the:defaultthreadpool-t1,0:interactivethreadpool during precompilation/PackageCompilerIssues