-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
runtime_intrinsics.c: Correct max_double
#57124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added tests would be prudent 🙂 (although I know you were not the pr original author) |
A test would be good, but this also seems to me like a really good reason for us to move away from runtime intrinsics. They're much more possible to break without people noticing. |
I'm a bit confused by how this wasn't caught before. Regular uses of |
So there are 2 implementations of all of our intrinsics, the codegen implementation (in codegen.c or cgutils.c) which is the LLVM code that we generate when compiling the function, and the runtime.c implementation that gets called when the function is interpreted. |
#57119 (comment) suggested tests and where to put them. For example, but not limited to: julia> Core.Intrinsics.max_float(1.0, 2.0)
1.0
julia> Core.Intrinsics.max_float(1.0f0, 2.0f0)
2.0f0 |
Closes #57119.