trimming: Remove init.c from test
#58197
Merged
+5
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
added
trimming
|
We will still need this for executables though, if we want the nicer |
This PR is just to fix that CI has diverged from Our "Hello, world" for executables is broken right now, but CI thinks it is fine because it is building the executable differently. |
44 tasks
This accidentally diverged when JuliaLang#58141 was merged without adjusting the test to match (these tests shouldn't be re-implementing the `juliac` link step anyway, but they currently do) Unfortunately, this hid a bug where `jl_pathname_for_handle` does not understand the main executable.
topolarity
force-pushed
the
ct/rm-init-trimming-test
branch
from
1b45fae to
ff4e43c
Compare
|
Now that #58231 has landed, this should be viable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accidentally diverged when #58141 was merged without adjusting the test to match (these tests shouldn't be re-implementing the
juliaclink step anyway, but they currently do)Unfortunately, this hid a bug where
jl_pathname_for_handledoes not understand the main executable.