Skip to content

Print fallback REPL prompt before user input #58210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 30, 2025
Merged

Print fallback REPL prompt before user input #58210

merged 5 commits into from
Apr 30, 2025
+2 −1

Conversation

xal-0
Copy link
Member

@xal-0 xal-0 commented Apr 23, 2025

Using the fallback REPL interactively prints the prompt only after user input, making the scrollback confusing:

$ JULIA_FALLBACK_REPL=1 julia          
1 + 2
julia> 3

@xal-0 xal-0 added the bugfix This change fixes an existing bug label Apr 23, 2025
@LilithHafner LilithHafner requested a review from vtjnash April 24, 2025 16:31
vtjnash
vtjnash reviewed Apr 24, 2025
View reviewed changes
xal-0 and others added 2 commits April 25, 2025 11:35
@vtjnash vtjnash added merge me PR is reviewed. Merge when all tests are passing backport 1.12 Change should be backported to release-1.12 labels Apr 28, 2025
@KristofferC KristofferC mentioned this pull request Apr 29, 2025
Open
44 tasks
@xal-0 xal-0 merged commit ccef01a into JuliaLang:master Apr 30, 2025
6 of 7 checks passed
@xal-0 xal-0 deleted the fallback-repl-prompt branch April 30, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
backport 1.12 Change should be backported to release-1.12 bugfix This change fixes an existing bug merge me PR is reviewed. Merge when all tests are passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xal-0 @vtjnash @DilumAluthge