-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
improve isdefined precision for 0 field types #58220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
oscardssmith
merged 10 commits into
JuliaLang:master
from
oscardssmith:os/improve-isdefined-inference
May 3, 2025
Merged
improve isdefined precision for 0 field types #58220
oscardssmith
merged 10 commits into
JuliaLang:master
from
oscardssmith:os/improve-isdefined-inference
May 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Apr 24, 2025
Co-authored-by: Jeff Bezanson <[email protected]>
JeffBezanson
approved these changes
Apr 24, 2025
Co-authored-by: Jeff Bezanson <[email protected]>
vtjnash
reviewed
Apr 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about Tuple? Those can throw also
nsajko
reviewed
Apr 25, 2025
vtjnash
reviewed
Apr 25, 2025
vtjnash
approved these changes
May 2, 2025
JeffBezanson
approved these changes
May 2, 2025
aviatesk
pushed a commit
that referenced
this pull request
May 3, 2025
alternate to #58214. --------- Co-authored-by: Jeff Bezanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternate to #58214.