Open
Conversation
Member
IanButterworth
left a comment
IanButterworth
left a comment
There was a problem hiding this comment.
If this is wrong it would be good to have a test that shows it was, and is now fixed.
Member
Author
|
Sadly won't have time to figure out testing for this myself (seems really tricky to test this), but I'll leave this open in case someone else wants to try in a fork of the branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While messing around in #1242 I noticed this. I'm pretty sure
create_symlinkshould be getting the updatedchannel_data, rather than simply propagating the previous info. I think this means that a symlink would have its version info forever frozen.