Pass GlobalPaths to save_config_db instead of re-deriving from current_exe#1424
Open
IanButterworth wants to merge 1 commit intomainfrom
Open
Pass GlobalPaths to save_config_db instead of re-deriving from current_exe#1424IanButterworth wants to merge 1 commit intomainfrom
save_config_db instead of re-deriving from current_exe#1424IanButterworth wants to merge 1 commit intomainfrom
Conversation
…t_exe During installation, save_config_db() called get_paths() which derives the self-config path from std::env::current_exe(). When the installer binary runs from a different filesystem than ~/.julia/ (e.g. /tmp), NamedTempFile::persist() fails with EPERM because rename(2) cannot cross filesystem boundaries. Fix by accepting &GlobalPaths as a parameter so callers pass the correct paths, especially during installation where the installer overrides paths to point to the install target. Fixes #1360 Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During installation, save_config_db() called get_paths() which derives the self-config path from std::env::current_exe(). When the installer binary runs from a different filesystem than ~/.julia/ (e.g. /tmp), NamedTempFile::persist() fails with EPERM because rename(2) cannot cross filesystem boundaries.
Fix by accepting &GlobalPaths as a parameter so callers pass the correct paths, especially during installation where the installer overrides paths to point to the install target.
Fixes #1360
Figured out, fixed, and above written by claude