Avoid warning with empty upper triangular solves (#442)

* Avoid warning with empty upper triangular solves * add seed! to broadcast tests * Update test_broadcasting.jl
JuliaLinearAlgebra · Jun 3, 2024 · eb47cc2 · eb47cc2 · dlfivefifty · Jun 3, 2024
1 parent 8618b18
commit eb47cc2
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 8 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "BandedMatrices"
 uuid = "aae01518-5342-5314-be14-df237901396f"
-version = "1.7"
+version = "1.7.1"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

diff --git a/src/blas.jl b/src/blas.jl
@@ -130,11 +130,13 @@ for (fname, elty) in ((:dtbsv_,:Float64),
                 throw(DimensionMismatch("size of A is $n != length(x) = $(length(x))"))
             end
             chkstride1(A)
-            ccall((@blasfunc($fname), libblas), Cvoid,
-                (Ref{UInt8}, Ref{UInt8}, Ref{UInt8}, Ref{BlasInt}, Ref{BlasInt},
-                 Ptr{$elty}, Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt}),
-                 uplo, trans, diag, m, k,
-                 A, max(1,stride(A,2)), x, stride(x, 1))
+            if n ≠ 0 # avoid empty warning message
+                ccall((@blasfunc($fname), libblas), Cvoid,
+                    (Ref{UInt8}, Ref{UInt8}, Ref{UInt8}, Ref{BlasInt}, Ref{BlasInt},
+                    Ptr{$elty}, Ref{BlasInt}, Ptr{$elty}, Ref{BlasInt}),
+                    uplo, trans, diag, m, k,
+                    A, max(1,stride(A,2)), x, stride(x, 1))
+            end
             x
         end
         function tbsv(uplo::AbstractChar, trans::AbstractChar, diag::AbstractChar,

diff --git a/test/test_broadcasting.jl b/test/test_broadcasting.jl
@@ -1,10 +1,12 @@
 module TestBroadcasting
 
-using BandedMatrices, LinearAlgebra, ArrayLayouts, FillArrays, Test
+using BandedMatrices, LinearAlgebra, ArrayLayouts, FillArrays, Random, Test
 import Base: BroadcastStyle
 import Base.Broadcast: broadcasted
 import BandedMatrices: BandedStyle, BandedRows, BandError
 
+Random.seed!(0)
+
 @testset "broadcasting" begin
     @testset "general" begin
         n = 1000
@@ -40,7 +42,9 @@ import BandedMatrices: BandedStyle, BandedRows, BandError
             @test 1 .+ A isa BandedMatrix
             @test (1 .+ A) == 1 .+ Matrix(A)
 
-            @test 1 .\ A == 1 .\ Matrix(A)
+            if VERSION ≥ v"1.10" # avoid failure on CI with Mac OS Julia v1.6
+                @test 1 .\ A == 1 .\ Matrix(A)
+            end
             @test 1 .\ A isa BandedMatrix
             @test bandwidths(1 .\ A) == bandwidths(A)
 

diff --git a/test/test_tribanded.jl b/test/test_tribanded.jl
@@ -114,6 +114,11 @@ import BandedMatrices: BandedColumns, BandedRows, isbanded
         @test rot180(LowerTriangular(B)) == rot180(Matrix(LowerTriangular(B)))
         @test rot180(UnitLowerTriangular(B)) == rot180(Matrix(UnitLowerTriangular(B)))
     end
+
+    @testset "empty uppertriangular" begin
+        B = brand(0,0,2,1)
+        @test UpperTriangular(B) \ Float64[] == Float64[]
+    end
 end
 
 end # module