Fix bug in ∞ cholesky (#85)

* Fix bug in ∞ cholesky * v0.5.11
JuliaLinearAlgebra · Jul 15, 2021 · 8ab7802 · 8ab7802 · dlfivefifty · Jul 15, 2021
1 parent f6a6782
commit 8ab7802
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "InfiniteLinearAlgebra"
 uuid = "cde9dba0-b1de-11e9-2c62-0bab9446c55c"
-version = "0.5.10"
+version = "0.5.11"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

diff --git a/src/infcholesky.jl b/src/infcholesky.jl
@@ -26,7 +26,7 @@ function partialcholesky!(F::AdaptiveCholeskyFactors{T,<:BandedMatrix}, n::Int)
         factors = view(F.data.data,kr,kr)
         banded_chol!(factors, UpperTriangular)
         # multiply remaining columns
-        kr2 = max(n-u+1,1):n
+        kr2 = max(n-u+1,kr[1]):n
         U1 = UpperTriangular(view(F.data.data,kr2,kr2))
         B = view(F.data.data,kr2,n+1:n+u)
         ldiv!(U1',B)

diff --git a/test/test_infcholesky.jl b/test/test_infcholesky.jl
@@ -25,5 +25,7 @@ using InfiniteLinearAlgebra, LinearAlgebra, BandedMatrices, ArrayLayouts, Test
     @testset "powers" begin
         b = [1; zeros(∞)]
         @test cholesky(S^2) \ b ≈ qr(S^2) \ b ≈ S^2 \ b
+
+        @test cholesky(S^2).U[1:100,1:100] ≈ cholesky(Symmetric((S^2)[1:100,1:100])).U
     end
 end