Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent runaway QL #183

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Prevent runaway QL #183

merged 3 commits into from
Jun 11, 2024

Conversation

TSGut
Copy link
Contributor

@TSGut TSGut commented Jun 6, 2024

I was looking at the design differences mentioned in the comments of #179 and spotted that these while loop protections in the (already existing) QL are very 'optimistic'. Doesn't seem to have caused issues for anyone but it still shouldn't enter an infinite loop.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (f2fe965) to head (bfda579).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   82.32%   83.10%   +0.77%     
==========================================
  Files          11       12       +1     
  Lines        1420     1509      +89     
==========================================
+ Hits         1169     1254      +85     
- Misses        251      255       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TSGut
Copy link
Contributor Author

TSGut commented Jun 10, 2024

@dlfivefifty I don't have merge rights on JuliaLinearAlgebra, is this good to go?

@dlfivefifty
Copy link
Member

Can you add a test?

@TSGut
Copy link
Contributor Author

TSGut commented Jun 11, 2024

Done. When you / we / Daniel think(s) about unification of the adaptive QL, reverse Cholesky etc. they should also think about doing this in a more clever or at least user-accessible way. It's really just a fix to an existing but broken max iteration atm.

@dlfivefifty dlfivefifty merged commit 20304e2 into JuliaLinearAlgebra:master Jun 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants