Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add krontrav function #140

Merged
merged 6 commits into from
Jan 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "LazyBandedMatrices"
uuid = "d7e5e226-e90b-4449-9968-0f923699bf6f"
authors = ["Sheehan Olver <[email protected]>"]
version = "0.11.0"
version = "0.11.1"

[deps]
ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
Expand Down
5 changes: 5 additions & 0 deletions src/blockkron.jl
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,11 @@ function _krontrav_mul_diagtrav((A,B,C), X::AbstractArray{<:Any,3}, ::Type{T}) w
DiagTrav(Y)
end

kron_materialize_layout(_, K) = BlockedArray(K)
kron_materialize_layout(::AbstractBandedBlockBandedLayout, K) = BandedBlockBandedMatrix(K)
kron_materialize(K) = kron_materialize_layout(MemoryLayout(K), K)
krontrav(A...) = kron_materialize(KronTrav(A...))



# C = α*B*X*A' + β*C
23 changes: 22 additions & 1 deletion test/test_blockkron.jl
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
module TestBlockKron

using LazyBandedMatrices, FillArrays, BandedMatrices, BlockBandedMatrices, BlockArrays, ArrayLayouts, LazyArrays, Test

using LinearAlgebra
import BlockBandedMatrices: isbandedblockbanded, isbanded, BandedBlockBandedStyle, BandedLayout, _BandedBlockBandedMatrix
import LazyBandedMatrices: KronTravBandedBlockBandedLayout, BroadcastBandedLayout, BroadcastBandedBlockBandedLayout, arguments, call, blockcolsupport, InvDiagTrav, invdiagtrav, pad
import LazyBandedMatrices: KronTravBandedBlockBandedLayout, BroadcastBandedLayout, BroadcastBandedBlockBandedLayout, arguments, call, blockcolsupport, InvDiagTrav, invdiagtrav, pad, krontrav
import ArrayLayouts: FillLayout, OnesLayout
import LazyArrays: resizedata!, FillLayout, arguments, colsupport, call, LazyArrayStyle
import BandedMatrices: BandedColumns
Expand Down Expand Up @@ -333,6 +334,26 @@ LinearAlgebra.factorize(A::MyLazyArray) = factorize(A.data)
x = DiagTrav(C)
@test D*x ≈ Matrix(D) * Vector(x)
end

@testset "krontrav" begin
a = [1,2,3]
b = [4,5,6]
c = [7,8,9]
@test krontrav(a,b) == KronTrav(a,b)
@test krontrav(a,b,c) == KronTrav(a,b,c)
@test krontrav(a,b) isa BlockedVector
@test krontrav(a,b,c) isa BlockedVector

A = [1 2; 3 4]
B = [5 6; 7 8]
@test krontrav(A,B) == KronTrav(A,B)
@test krontrav(A,B) isa BlockedMatrix

n = 4
Δ = BandedMatrix(1 => Ones(n-1), 0 => Fill(-2,n), -1 => Ones(n-1))
@test krontrav(Δ,Eye(n)) == KronTrav(Δ, Eye(n))
@test krontrav(Δ,Eye(n)) isa BandedBlockBandedMatrix
end
end

end # module
Loading