Skip to content

select intermediate destination of CompositionMap based on input #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 30, 2019
Merged

Conversation

kose-y
Copy link
Contributor

@kose-y kose-y commented Dec 27, 2019

I was trying to use LinearMap with a CuArray, and this issue blocked me.

@coveralls
Copy link

coveralls commented Dec 27, 2019

Coverage Status

Coverage increased (+0.9%) to 95.042% when pulling a4c334b on kose-y:master into e67dd8f on Jutho:master.

@codecov
Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          10       10           
  Lines         621      621           
=======================================
  Hits          600      600           
  Misses         21       21
Impacted Files Coverage Δ
src/composition.jl 98.41% <100%> (ø) ⬆️
src/kronecker.jl 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e67dd8f...a4c334b. Read the comment docs.

@dkarrasch
Copy link
Member

Thanks, this LGTM. While you're at it, could you please also replace the two Array constructors in kronecker.jl, lines 109-110?

@kose-y
Copy link
Contributor Author

kose-y commented Dec 29, 2019

Sure.

@dkarrasch
Copy link
Member

Thanks once more. Now I realize that we may actually not need the T = eltype(y)/Ty = eltype(y) stuff (in both cases), since the default is y's eltype anyway. Could you please remove them?

@dkarrasch dkarrasch merged commit f2c533c into JuliaLinearAlgebra:master Dec 30, 2019
@dkarrasch
Copy link
Member

Many thanks for your contribution. I'll release this soonish after #72 is merged as v2.6.

@Jutho
Copy link
Collaborator

Jutho commented Jan 2, 2020

Much better indeed, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants