Fix solve_exp_ode not updating position #748
Merged
+25
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! The one small hint failing is an entry in the changeling (NEWS.md), if you could add that as well, this looks perfect! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #748 +/- ##
=======================================
Coverage 99.69% 99.69%
=======================================
Files 123 123
Lines 11415 11415
=======================================
Hits 11380 11380
Misses 35 35 ☔ View full report in Codecov by Sentry. |
|
Should I just add a new minor version number for this? |
|
yes, as date you could put “unreleased” we will add the date when we register the new version; for the rest just follow the scheme that is already there :) |
kellertuer
approved these changes
Sep 14, 2024
mateuszbaran
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #744 and fixes #740. Also add some new tests that fail without the fix for #744.