Change storage and evaluation point order. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=======================================
Coverage 83.92% 83.92%
=======================================
Files 2 2
Lines 56 56
=======================================
Hits 47 47
Misses 9 9
Continue to review full report at Codecov.
|
|
I'll fix LineSearches.jl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this is going to wreak havoc, but let's just get this out there before Julia v1.0 hits, and people start producing code bases that will live for years. No way we can deprecate this as far as I see it.
cc: @anriseth
cross ref JuliaNLSolvers/Optim.jl#156 JuliaNLSolvers/Optim.jl#326