Skip to content

remove dead code (detect_libstdcxx_version and check_libstdcxx_version) ? #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Jul 12, 2025

It looks like BinaryBuilder.Auditor.detect_libstdcxx_version and BinaryBuilder.Auditor.check_libstdcxx_version is dead code and not used anywhere in BinaryBuilder, also without any traces of usage anywhere else in the julia ecosystem:
https://github.com/JuliaPackaging/BinaryBuilder.jl/blob/master/src/auditor/compiler_abi.jl#L107-L165

So should they be removed ?

Hoisted out of #1392.

@giordano
Copy link
Member

I never touched this code because I always assumed this was meant to be used at some point, since Julia itself also has mechanisms to detect the libstdc++ version (on Linux do Base.BinaryPlatform.HostPlatform()).

@t-bltg
Copy link
Contributor Author

t-bltg commented Jul 16, 2025

Ok, I wanted to add tests covering these lines, but they were failing, so I'm not sure what to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants