remove dead code (detect_libstdcxx_version
and check_libstdcxx_version
) ?
#1394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
BinaryBuilder.Auditor.detect_libstdcxx_version
andBinaryBuilder.Auditor.check_libstdcxx_version
is dead code and not used anywhere inBinaryBuilder
, also without any traces of usage anywhere else in thejulia
ecosystem:https://github.com/JuliaPackaging/BinaryBuilder.jl/blob/master/src/auditor/compiler_abi.jl#L107-L165
So should they be removed ?
Hoisted out of #1392.