Skip to content

Refactor the SLURM_NTASKS and SLURM_JOB_ID functionality out into separate utility functions, and add some more unit tests to increase code coverage #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Refactor the SLURM_NTASKS and SLURM_JOB_ID functionality out into separate utility functions, and add some more unit tests to increase code coverage #44

wants to merge 2 commits into from

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Feb 7, 2025 •
edited
Loading

@DilumAluthge DilumAluthge mentioned this pull request Feb 7, 2025
Merged
1 task
@DilumAluthge DilumAluthge changed the base branch from master to dpa/code-coverage-2 February 7, 2025 20:08
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.11%. Comparing base (848448c) to head (092db15).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   89.36%   94.11%   +4.75%     
==========================================
  Files           2        2              
  Lines          94      102       +8     
==========================================
+ Hits           84       96      +12     
+ Misses         10        6       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DilumAluthge
Copy link
Member Author

Code coverage on dpa/code-coverage-2 (#42) is 89%.

Code coverage on this PR is 93%.

@DilumAluthge DilumAluthge mentioned this pull request Feb 9, 2025
Merged
Base automatically changed from dpa/code-coverage-2 to master February 16, 2025 19:26
@DilumAluthge DilumAluthge marked this pull request as ready for review February 19, 2025 00:19
@DilumAluthge
Refactor the SLURM_NTASKS and SLURM_JOB_ID functionality out into…
7692b64 
… separate utility functions, and add some more unit tests to increase code coverage
@DilumAluthge DilumAluthge marked this pull request as draft March 24, 2025 00:46
@DilumAluthge DilumAluthge removed the request for review from kleinhenz March 24, 2025 00:46
@DilumAluthge
Test suite: Add more test coverage for warn_if_unexpected_params() …
092db15 
…(only on Julia versions prior to 1.6) (#45)

Depends on:
- [ ] #44
@DilumAluthge DilumAluthge deleted the dpa/ntasks branch April 29, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DilumAluthge