Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix AutoCalibration #59

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

theHenks
Copy link
Contributor

Prevent auto calibration to get stuck in infinite while loop when trying to determine the calibration constant through peak ratios.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.36%. Comparing base (4d23146) to head (3a53470).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/AutoCalibration/AutoCalibration.jl 72.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   89.83%   89.36%   -0.48%     
==========================================
  Files          10       10              
  Lines         610      630      +20     
==========================================
+ Hits          548      563      +15     
- Misses         62       67       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oschulz oschulz merged commit 6b3e572 into JuliaPhysics:main Dec 18, 2024
7 of 9 checks passed
@oschulz
Copy link
Member

oschulz commented Dec 18, 2024

@theHenks theHenks deleted the patch_auto-calibration branch December 18, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants