Adapt @with to work with minor change from JuliaSyntax.jl
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c42f
changed the title
@compact to work with minor change from JuliaSyntax.jl@with to work with minor change from JuliaSyntax.jl
|
Oops, sorry for the weird copy and paste in the message, I forgot to change it from the sibling PR at FluxML/Fluxperimental.jl#9 |
The reference parser parses the `=` in `@x(y=1)` as `Expr(:(=))` but the `=` in `@x(y=1) do y end` as `Expr(:kw)`. In JuliaSyntax, we've corrected this inconsistency as a minor change to the parsing rules, but this breaks the `@with` macro in this package (And one macro in `Fluxperimental` - the only two cases in General.) Found as part of the integration work in JuliaLang/julia#46372
c42f
force-pushed
the
c42f/fix-macro-do-kws
branch
from
1edac50 to
6f175d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference parser parses the
=in@x(y=1)asExpr(:(=))but the=in@x(y=1) do y endasExpr(:kw). In JuliaSyntax, we've corrected this inconsistency as a minor change to the parsing rules, but this breaks the@withmacro in this package (And one macro inFluxperimental- the only two cases in General.)Found as part of the integration work in JuliaLang/julia#46372