Use scale for linear map with IdentityMultiple
#892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
reviewed
Apr 8, 2025
| @@ -507,7 +507,7 @@ end | |||
| _wrap_invariant(X::LazySet, ::Int) = X | |||
| _wrap_invariant(::Nothing, n::Int) = Universe(n) | |||
|
|
|||
| _wrap_inputs(U::AbstractInput, B::IdentityMultiple) = isidentity(B) ? U : map(u -> B * u, U) | |||
| _wrap_inputs(U::AbstractInput, B::IdentityMultiple) = isidentity(B) ? U : map(u -> scale(B.M.λ, u), U) | |||
There was a problem hiding this comment.
isn't B * u not using internally the scale method? what is the advantage of using scale?
There was a problem hiding this comment.
Why would the lazy operation use scale?
The advantage is that the added test now works. Without this change, the test crashes. I do not remember the details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue uncovered in #889.
The proposed change assumes that
scaleis available for the input set. This currently holds at least for the common input sets (Singleton,Hyperrectangle,Zonotope).