Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prototype nullhypo parametric with robust kernel #1808

Closed
wants to merge 6 commits into from

Conversation

dehann
Copy link
Member

@dehann dehann commented Dec 9, 2023

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (dbdeab3) 76.81% compared to head (9e3e321) 76.71%.

Files Patch % Lines
src/parametric/services/ParametricUtils.jl 26.92% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1808      +/-   ##
==========================================
- Coverage   76.81%   76.71%   -0.10%     
==========================================
  Files          82       82              
  Lines        5977     5986       +9     
==========================================
+ Hits         4591     4592       +1     
- Misses       1386     1394       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Affie
Copy link
Member

Affie commented Dec 11, 2023

Are you suggesting that we revive the optim.jl solver code? This is currently just kept until the tree solve and mixtures can be updated to manopt. As far as i know it’s not used anywhere.
I had it that CalcFactorResidual would replace CalcFactorMahalanobus.

@dehann
Copy link
Member Author

dehann commented Jan 21, 2024

Hi Affie, no lets go for Manopt. Was just easier to start the coding cycle against coordinates here. We can copy from this code for future work.

[sic] Malahanobis

@dehann
Copy link
Member Author

dehann commented Mar 8, 2024

Note that we have not added this into main via another PR just yet -- still TODO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants