Repository navigation
Accept AWS regions by name shape instead of a fixed list - #94
Merged
Merged
Conversation
URL parsing checked regions against a hard-coded set of 31 names, so URLs in regions AWS opened since (ap-southeast-5, ap-southeast-7, mx-central-1, ap-east-2, ...) failed with "Validation failed for `region`" before any request. Check the shape of a region name instead: <area>-<subarea>...-<n>. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
=======================================
Coverage 90.31% 90.31%
=======================================
Files 8 8
Lines 1053 1053
=======================================
Hits 951 951
Misses 102 102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
quinnj
referenced
this pull request
Oct 22, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL parsing (
CloudStore.get(url),S3.get(url), etc.) checked the region against a hard-coded set of 31 names. URLs in regions AWS opened since then (for examplehttps://bucket.s3.ap-southeast-5.amazonaws.com/key, also ap-southeast-7, mx-central-1, ap-east-2) failed withArgumentError: Validation failed for regionbefore any request was sent.validate_regionnow checks the shape of a region name (<area>-<subarea>…-<number>:us-east-1,ap-southeast-5,us-gov-west-1), so new regions keep working. A typo such asus-eest-1now passes validation and fails at DNS instead.Test change: the negative case used
no-region-1, which is well formed; it now uses the malformedno_region, and four real regions (two of them missing from the old list) parse. 119/119 pass; onmainthe new-region cases error. Full suite passes locally.🤖 Generated with Claude Code