backport LOADPATH fix #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include new tests
Make sure it really deactivated Apply suggestions from code review
Codecov Report
@@ Coverage Diff @@
## release-1.4 #24 +/- ##
================================================
+ Coverage 60.30% 78.75% +18.44%
================================================
Files 6 4 -2
Lines 131 80 -51
================================================
- Hits 79 63 -16
+ Misses 52 17 -35
Continue to review full report at Codecov.
|
mmiller-max
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this backport #20 to release-1.4
and closes #19
It is built on top of #22 and requires that to be merged first.
The PR as it is only a backport of already approved #20 does not require review