Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restict versions and release as 1.4 #7

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Restict versions and release as 1.4 #7

merged 2 commits into from
Aug 2, 2021

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Aug 1, 2021

@mmiller-max what do you think?
This initial release will support 1.4, 1.5, 1.6 and will be called TestEnv v1.4

This implements part of #4

Then we can fork off this later to release 1.0.x that supports julia 1.0,
etc

@oxinabox oxinabox changed the base branch from main to release-1.4 August 1, 2021 21:59
@mmiller-max
Copy link
Member

Yeah this is a good idea. Putting the three versions together is good. Do you want to remove the code from other versions ad refactor as you've done in other branches? Could be done in later PRs (or there may be an argument to keep it)

@oxinabox
Copy link
Member Author

oxinabox commented Aug 2, 2021

Could be done in later PRs

Yeah, I figure no sense changing this now, better to get something working out, can change it later.

Do you approve this one?

@mmiller-max
Copy link
Member

mmiller-max commented Aug 2, 2021

How would you see this being used by something like TestReports, which also currently supports a few Julia versions? Would something like having no compat entry for TestEnv result in it having the latest patch version of the compatible branch? Otherwise I'm worried we would need different compat entires for different Julia versions

@oxinabox
Copy link
Member Author

oxinabox commented Aug 2, 2021

Would something like having no compat entry for TestEnv result in it having the latest patch version of the compatible branch

Yes, if the compat is set to 1 or equivalently 1.0 or 1.0 or 1.0.0 or ^1, or ^1.0 or ^1.0 or ^1.0.0,
then the package manager is free to choose any compatible versiox v with 1.0.0 <= v < 2.0.0
SO it would just chose the latest patch for some compatible version of julia

@oxinabox oxinabox merged commit 53390df into release-1.4 Aug 2, 2021
@oxinabox oxinabox deleted the ox/restrict branch August 2, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants