Skip to content

Format code and add checking workflow #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Format code and add checking workflow #70

wants to merge 2 commits into from

Conversation

pitmonticone
Copy link
Member

Changes

  • Format all scripts according to "blue" style
  • Add format checking workflow

@pitmonticone pitmonticone requested a review from pat-alt March 21, 2023 18:05
@pitmonticone pitmonticone self-assigned this Mar 21, 2023
pat-alt
pat-alt reviewed Mar 22, 2023
View reviewed changes
Copy link
Member

@pat-alt pat-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The reason these two PRs are not passing is that the updated version of CounterfactualExplanations.jl brought some breaking changes. Shouldn't be two hard to fix, but I won't get to it any time soon (got my head stuck in a paper submission). We can downgrade CounterfactualExplanantions to 0.1.8 or 0.1.7, if you'd like to see this merged asap.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pat-alt pat-alt pat-alt left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@pitmonticone pitmonticone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pitmonticone @pat-alt