Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shell completions output directory #104

Closed
wants to merge 1 commit into from

Conversation

orhun
Copy link
Contributor

@orhun orhun commented Aug 18, 2024

I realized the shell completions generation was added in the last release so I have it a try for the Arch package:

$ atac completions -h

atac completions [OPTIONS] <SHELL> [OUTPUT_DIRECTORY]

$ atach completions bash target

error: unexpected argument '--directory' found

Uhh, what?

It turns out --directory argument was necessary for all cases so the correct command would be:

$ atac completions --directory target completions bash

I don't find this intuitive - and it clashes with the help message. So I fixed this in this PR and made the following possible:

$ atac completions bash target

Completions file generated into "target"

Also, it shows an error if you don't provide any directories as the trailing argument. (We can probably improve the error message there so LMK)

@Julien-cpsn
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants