Skip to content

changed ascii decode to utf8 in handleing of "WHAT IS THIS" #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

changed ascii decode to utf8 in handleing of "WHAT IS THIS" #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83a4f8d
fix(error-reporting): changed from ascii decoding to utf8
dk949 Nov 30, 2021
24b8b3b
chore(changelog): added to the changelog now so I don't forget later
dk949 Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Change Log

## [0.0.7](https://github.com/JumpCutter/JC-render/compare/v0.0.6...v0.0.7) (2021-11-30)


## Bug Fixes
- __ascii__ : stderr from WHAT IS THIS now decoded with utf8 so decode doesn't throw with
non ascii characters in video file name

## [0.0.6](https://github.com/JumpCutter/JC-render/compare/v0.0.5...v0.0.6) (2021-07-23)

Expand Down
2 changes: 1 addition & 1 deletion render.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ def has_stream(self, file_name, stream='v'): # NOQA
probe_all = ffmpeg.probe('{}'.format(file_name), cmd=self.ffprobe_path)
except Exception as e:
self.logger.warning("WHAT IS THIS") # FIXME: @JUL14N this one's for you buddy:)
stderr = e.stderr.decode('ascii').replace('\n', '\n\t')
stderr = e.stderr.decode('utf8').replace('\n', '\n\t')
self.logger.warning(f"ffprobe stderr:\n\t{stderr}")
if stream == 'v':
self.logger.debug("probe result -\n" + json.dumps(probe_all, indent=2))
Expand Down