Minor tweaks found when trying to use with digitalrebar #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansible hostname returns the first part of FQDN. Ansible nodename returns what hostname returns.
galthaus
changed the title
| opencontrail_host_kernel_artifact_tar: "/tmp/.ansible/opencontrail-vrouter-{{ opencontrail_host_kernel_tag }}.tgz" | ||
|
|
||
| # Allow the system to have a way to override arp discovery of vrouters | ||
| opencontrail_no_arp: false |
There was a problem hiding this comment.
I'd prefer if this parameter was called:
opencontrail_physical_network_arp_support
with a default of true.
There was a problem hiding this comment.
Sounds good
Sent from my iPhone
On Feb 17, 2016, at 6:09 PM, Pedro Marques [email protected] wrote:
In roles/opencontrail/vars/main.yml:
\ No newline at end of file
+opencontrail_host_kernel_artifact_tar: "/tmp/.ansible/opencontrail-vrouter-{{ opencontrail_host_kernel_tag }}.tgz"
+
+# Allow the system to have a way to override arp discovery of vrouters
+opencontrail_no_arp: false
I'd prefer if this parameter was called:
opencontrail_physical_network_arp_support
with a default of true.—
Reply to this email directly or view it on GitHub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to toggle whether to use arp or not generally (but for google case).
Make sure the we only write out the open contrail private field if has a value in it.
Switch the ansible_hostname use to ansible_nodename to ensure that the places that use hostname
match what the node returns when running the hostname command.