MDL-67353 course: move form tearDown() to reset_all_data()

We are already cleaning all sort of caches, statics, singletons
there and it's better to ensure they are always reset to avoid
myterious failures @ distance.

course/classes/customfield/course_handler.php

@@ -71,7 +71,7 @@ public static function create(int $itemid = 0) : \core_customfield\handler {
     /**
      * Run reset code after unit tests to reset the singleton usage.
      */
-    public static function reset_after_test(): void {
+    public static function reset_caches(): void {
         if (!PHPUNIT_TEST) {
             throw new \coding_exception('This feature is only intended for use in unit tests');
         }

customfield/tests/api_test.php

@@ -37,14 +37,6 @@
  */
 class core_customfield_api_testcase extends advanced_testcase {
 
-    /**
-     * Tear down to reset the singleton after each test.
-     */
-    public function tearDown() {
-        core_course\customfield\course_handler::reset_after_test();
-        parent::tearDown();
-    }
-
     /**
      * Get generator.
      *

customfield/tests/category_controller_test.php

@@ -36,14 +36,6 @@
  */
 class core_customfield_category_controller_testcase extends advanced_testcase {
 
-    /**
-     * Tear down to reset the singleton after each test.
-     */
-    public function tearDown() {
-        core_course\customfield\course_handler::reset_after_test();
-        parent::tearDown();
-    }
-
     /**
      * Get generator.
      *

customfield/tests/data_controller_test.php

@@ -34,14 +34,6 @@
  */
 class core_customfield_data_controller_testcase extends advanced_testcase {
 
-    /**
-     * Tear down to reset the singleton after each test.
-     */
-    public function tearDown() {
-        core_course\customfield\course_handler::reset_after_test();
-        parent::tearDown();
-    }
-
     /**
      * Get generator.
      *

customfield/tests/field_controller_test.php

@@ -38,14 +38,6 @@
  */
 class core_customfield_field_controller_testcase extends advanced_testcase {
 
-    /**
-     * Tear down to reset the singleton after each test.
-     */
-    public function tearDown() {
-        core_course\customfield\course_handler::reset_after_test();
-        parent::tearDown();
-    }
-
     /**
      * Get generator.
      *

customfield/tests/generator_test.php

@@ -35,14 +35,6 @@
  */
 class core_customfield_generator_testcase extends advanced_testcase {
 
-    /**
-     * Tear down to reset the singleton after each test.
-     */
-    public function tearDown() {
-        core_course\customfield\course_handler::reset_after_test();
-        parent::tearDown();
-    }
-
     /**
      * Get generator
      * @return core_customfield_generator

customfield/tests/privacy_test.php

@@ -38,14 +38,6 @@
  */
 class core_customfield_privacy_testcase extends provider_testcase {
 
-    /**
-     * Tear down to reset the singleton after each test.
-     */
-    public function tearDown() {
-        core_course\customfield\course_handler::reset_after_test();
-        parent::tearDown();
-    }
-
     /**
      * Generate data.
      *

lib/phpunit/classes/util.php

@@ -252,6 +252,9 @@ public static function reset_all_data($detectchanges = false) {
         if (class_exists('\core\update\checker')) {
             \core\update\checker::reset_caches(true);
         }
+        if (class_exists('\core_course\customfield\course_handler')) {
+            \core_course\customfield\course_handler::reset_caches();
+        }
 
         // Clear static cache within restore.
         if (class_exists('restore_section_structure_step')) {