New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct makeBibliography() documentation #24

Open

outboundexplorer wants to merge 1 commit into Juris-M:master from outboundexplorer:master

Contributor

outboundexplorer commented Apr 16, 2019

entry_ids is an array of arrays


          Correct makeBibliography() documentation

96a6f35

entry_ids is an array of arrays

Contributor

fbennett commented Apr 16, 2019

That looks odd, doesn't it. I wonder if this was even by intention. I'll double-check that it's doing that, then take your commit.

Contributor Author

outboundexplorer commented Apr 16, 2019 via email

That’s what I figured. I’m not ready to look deeper into the code at the moment. Although, my gut feeling is that there is no need for these to be returned as an array. On 16 Apr 2019, at 10:44, Frank Bennett <[email protected]<mailto:[email protected]>> wrote: That looks odd, doesn't it. I wonder if this was even by intention. I'll double-check that it's doing that, then take your commit. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJuris-M%2Fciteproc-js-docs%2Fpull%2F24%23issuecomment-483589338&data=02%7C01%7C%7Cff4db2de525e45516c9408d6c2501de5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636910046680760729&sdata=HKd%2F5JixgXIKsyWiitgYMe5NBPxycAuKu91gFpzix0k%3D&reserved=0>, or mute the thread<https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGctaMQCaETHq9qZyoHYs4rVhA1-3LVrks5vhZt5gaJpZM4cxxi3&data=02%7C01%7C%7Cff4db2de525e45516c9408d6c2501de5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636910046680770737&sdata=sVOSJcRH22h50mM8e9XazKsHgmjlZE0PBVHwLSBNAvQ%3D&reserved=0>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet