π :: (#23) connect account api #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defines the `AccountApi` interface using Retrofit for interacting with the account-related endpoints. This includes a method for retrieving the user's account information.
Adds the `MyAccountResponseDto` to represent the structure of the account information received from the remote API. This DTO includes fields for ID, KRW balance, and USD balance, using `freezed` for immutable data classes and `json_serializable` for JSON conversion. Also creates empty directories with `.gitkeep` for local request/response DTOs and remote request DTOs.
Implements the account data source interface. This retrieves user account information from the API.
Defines an abstract AccountRepository and its implementation, AccountRepositoryImpl, to handle fetching user account details. This setup provides a clear separation of concerns for data access and allows for easier testing and future modifications.
iloveuhyeon
added
the
κ°λ°
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR connects the Account API to the app, updates DI, and enforces new lint rules.
- Adds
flutter_lintsand updatesanalysis_options.yaml - Introduces
AccountApi, its data source, DTO, and DI registrations - Refactors controllers to return success booleans, updates navigation calls, and cleans up imports & const usage
Reviewed Changes
Copilot reviewed 40 out of 43 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Added flutter_lints |
| analysis_options.yaml | Enabled strict const and lint rules |
| lib/data/account/service/account_api.dart | New Retrofit API interface for account |
| lib/data/account/dto/remote/response/my_account_response_dto.dart | DTO for account response |
| lib/data/account/data_sources/account_data_source_impl.dart | Implementation of AccountDataSource |
| lib/data/account/data_sources/account_data_source.dart | AccountDataSource abstraction |
| lib/core/config/di/dependencies.dart | Registered AccountApi and AccountDataSource |
| lib/presentation/sign_up/controller/*.dart | Refactored start/sendVerificationCode to return bool |
| lib/presentation/sign_in/controller/sign_in_controller.dart | Refactored signIn to return bool |
| (multiple) | Various const/coding-style cleanups |
Comments suppressed due to low confidence (4)
pubspec.yaml:59
- The flutter_lints package is intended for development only and should be moved to
dev_dependenciesto avoid shipping linter code in production builds.
flutter_lints: ^6.0.0
lib/data/account/service/account_api.dart:1
- New account API endpoints have been added but no tests are included. Please add unit tests for
AccountApi.getMyAccount()(e.g., using a mock Dio) to ensure correct request formation and error handling.
import 'package:dio/dio.dart';
lib/core/config/di/dependencies.dart:42
- [nitpick] When registering
AccountApi, consider passing a namedbaseUrlor using the same instantiation pattern as other APIs to avoid inconsistencies if multiple base URLs are needed.
di.registerLazySingleton<AccountApi>(() => AccountApi(di.get<Dio>()));
analysis_options.yaml:1
- [nitpick] Enabled
prefer_const_declarationsandprefer_const_constructors, but many widgets lackconst. Consider runningdart fix --applyto update codebase and satisfy the new lint rules.
include: package:flutter_lints/flutter.yaml
| } | ||
|
|
||
| void signIn(BuildContext context) { | ||
| bool signIn() { |
There was a problem hiding this comment.
Similar to other controllers, signIn returns false before the async sign-in completes. Consider making this method async and await the use case so that the returned boolean reflects the real outcome.
Suggested change
| bool signIn() { | |
| Future<bool> signIn() async { |
aiden30015
previously approved these changes
Jul 8, 2025
Contributor
aiden30015
left a comment
aiden30015
left a comment
There was a problem hiding this comment.
μκ³ νμ ¨μ΅λλ€..
Co-authored-by: Copilot <[email protected]>
aiden30015
approved these changes
Jul 9, 2025
bluemoon983
approved these changes
Jul 9, 2025
Contributor
bluemoon983
left a comment
bluemoon983
left a comment
There was a problem hiding this comment.
μκ³ νμ ¨μ΅λλ€
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ κ°μ
π μμ λ΄μ©
π λ³κ²½μ¬ν
πββοΈ μ§λ¬Έμ¬ν
π΄ μ¬μ©λ°©λ²
πΈ κΈ°ν