🔀 :: (#34) Base Scaffold, Base Appbar 퍼블리싱

[iloveuhyeon]

💡 개요

• Base Scaffold를 퍼블리싱 했습니다
• Base Appbar를 퍼블리싱 했습니다

📃 작업내용

• 전역적으로 사용할 수 있는 Base Scaffold를 퍼블리싱하여 코드의 가독성을 높혔습니다.
• 전역적으로 사용할 수 있는 Base Appbar를 퍼블리싱하여 코드의 가독성을 높혔습니다.

🔀 변경사항

🙋‍♂️ 질문사항

🍴 사용방법

import '../../../core/config/widget/base_appbar.dart';
import '../../../core/config/widget/base_scaffold.dart';

class CandlestickChartScaffold extends BaseScaffold {
  const CandlestickChartScaffold({
    super.key,
    required this.candlestickChartWidget,
    required this.stocksInfoTabBar,
    required this.stocksInfoTabBarView,
  });

  final Widget candlestickChartWidget;
  final Widget stocksInfoTabBar;
  final Widget stocksInfoTabBarView;

  @override
  Widget buildBody(BuildContext context, WidgetRef ref) {
    return SingleChildScrollView(
      child: Padding(
        padding: EdgeInsets.symmetric(vertical: 16.h),
        child: Column(
          spacing: 24,
          children: [
            candlestickChartWidget,
            stocksInfoTabBar,
            stocksInfoTabBarView,
          ],
        ),
      ),
    );
  }

  @override
  PreferredSizeWidget? buildAppBar(BuildContext context, WidgetRef ref) {
    return BaseAppbar(
      title: '마이크로소프트',
      backButton: true,
      actionWidgets: [
        IconButton(
          onPressed: () {},
          icon: JusicoolIcon.setting(
            width: 24.w,
            height: 24.h,
            color: JusicoolColor.black,
          ),
        ),
      ],
    );
  }
}

🎸 기타

[Copilot]

Pull Request Overview

This PR publishes global BaseScaffold and BaseAppbar widgets to standardize scaffold layout and app bar styling across the app.

• Introduces BaseScaffold abstract widget with customizable background, SafeArea handling, and optional bottom navigation.
• Introduces BaseAppbar widget wrapping Flutter’s AppBar with default styling, back navigation support, and action slots.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
lib/core/config/widget/base_scaffold.dart	Added BaseScaffold with common Scaffold properties, SafeArea wrapper, and abstract hooks.
lib/core/config/widget/base_appbar.dart	Added BaseAppbar implementing PreferredSizeWidget to provide a styled AppBar template.

Comments suppressed due to low confidence (4)

lib/core/config/widget/base_appbar.dart:5

• Class name 'BaseAppbar' is inconsistent with Flutter's 'AppBar' naming. Consider renaming to 'BaseAppBar' for clarity.

class BaseAppbar extends StatelessWidget implements PreferredSizeWidget {

lib/core/config/widget/base_scaffold.dart:35

• [nitpick] The getter name 'setBottomSafeArea' reads like an action. Consider renaming to 'useBottomSafeArea' to indicate a boolean flag.

  bool get setBottomSafeArea => true;

lib/core/config/widget/base_scaffold.dart:38

• [nitpick] The getter name 'setTopSafeArea' is ambiguous. Rename to 'useTopSafeArea' to match 'useSafeArea' and clarify intent.

  bool get setTopSafeArea => true;

lib/core/config/widget/base_appbar.dart:5

• [nitpick] Add dartdoc comments to this public widget class and its constructor parameters to explain their purpose and usage.

class BaseAppbar extends StatelessWidget implements PreferredSizeWidget {

[Copilot]

The 'backButton' flag isn't used to conditionally render the back icon. Wrap this IconButton in an if (backButton) so it only shows when requested.

Suggested change

	leading: IconButton(
	onPressed: () {
	Navigator.of(context).pop();
	},
	icon: JusicoolIcon.backArrow(
	width: 24.w,
	height: 24.h,
	color: JusicoolColor.black,
	),
	),
	leading: backButton
	? IconButton(
	onPressed: () {
	Navigator.of(context).pop();
	},
	icon: JusicoolIcon.backArrow(
	width: 24.w,
	height: 24.h,
	color: JusicoolColor.black,
	),
	)
	: null,

[Copilot]

[nitpick] Use responsive padding with ScreenUtil (e.g., EdgeInsets.only(right: 24.w)) to maintain consistency across screen sizes.

Suggested change

	actionsPadding: EdgeInsets.only(right: 24),
	actionsPadding: EdgeInsets.only(right: 24.w),

[aiden30015]

수고하셨습니다

[DAMNyul]

적용하도록 하겠습니다! 수고하셨습니다!

[bluemoon983]

확인했습니다!