feat(approval-flow): add human approval hold flow#5
Merged
Conversation
…(task 1.1) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…cted schema mismatch (task 1.2) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…and timeout (task 2.1) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tion (task 2.3) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ng approval (task 3.1) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… register webhook endpoint
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- approval_bridge_integration_test: increase lockTTL to 2s so the session lock survives subscriber setup under the race detector - db_test: correct ticket status constraint assertion from "rejected" to "denied" to match the schema repair migration - main_test, policy_gate_integration_test: call CloseClientConnections() before Close() to avoid httptest.Server wg.Wait() deadlock when approval holds keep connections open - server_integration_test: handle initialize separately in the blocking upstream mock so upstreamStarted fires only for tools/call; guard close(releaseUpstream) with sync.Once; use r.Context().Done() select so cleanup can unblock the handler goroutine on test failure Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation