-
Notifications
You must be signed in to change notification settings - Fork 3
KDT0_CyinHayeon 디아블로 홈페이지 클론코딩 (기존 pr closed) #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sinary00
wants to merge
26
commits into
main
Choose a base branch
from
KDT0_CyinHayeon
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 18 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
1b6e484
Feat : Add project - diablo
Sinary00 3f6488d
Feat : Add favi icon
Sinary00 1b4ba24
Docs : Update Readme.md
Sinary00 afa65e9
Feat : Delete js
Sinary00 1414247
Feat : Update index.html - select
Sinary00 4a34489
Feat : Update index.html - select
Sinary00 cfd48c7
Feat : Update index.html - select
Sinary00 6679989
Feat : Fix select required
Sinary00 20f9a09
Docs : Update README.md
Sinary00 657af07
Feat : Merge header footer
Sinary00 9f69094
Feat : Loading lazy - image, iframe
Sinary00 b3d9354
Feat : Loading page fadein
Sinary00 4ae472f
Feat : Fix Loading Image
Sinary00 9ec2c3f
Docs : Update README.md
Sinary00 689bc22
Feat : Update visual css - main.css
Sinary00 78710b0
Feat : Fix tap button
Sinary00 b5f75e5
Feat : Update scrollTop menu js
Sinary00 7372491
Feat : Fix main.js - delete console.log
Sinary00 acdcfa3
Fix : Prettier
Sinary00 6a1752f
Fix : main.css - delete important
Sinary00 27a3631
Fix : main.css - visual_in height
Sinary00 335b06d
Fix : main.css - z-index
Sinary00 9c6e3cb
Fix : main.css - transition
Sinary00 0fa40c7
Fix : url - 절대경로
Sinary00 c60851e
Fix : index.html aria-label
Sinary00 81796a6
Fix : index.html role
Sinary00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,45 +1,44 @@ | ||
| [참고 내용] | ||
| # 디아블로4 홈페이지 클론 코딩 | ||
|
|
||
| 👀 자신이 원하는 사이트 레이아웃 클론 | ||
| 원하는 사이트(페이지)를 자유롭게 선택하고 레이아웃을 클론 코딩하세요. | ||
| 평소에 도전해 보고 싶었거나 혹은 자신의 수준에 맞는 사이트(페이지)를 선택하세요. | ||
| 과제 수행 및 리뷰 기간은 별도 공지를 참고하세요! | ||
| ## 사이트 주소 | ||
| + 원본 링크 : https://diablo4.blizzard.com/ko-kr/ | ||
| + 클론 코딩 배포 링크 : https://gleaming-mooncake-584e00.netlify.app/ | ||
|
|
||
| 과제 수행 및 제출 방법 | ||
| ## 작업 기간 | ||
| 2023년 7월 27일 ~ (진행중) | ||
| (과제 제출 후에도 보완 할 예정) | ||
|
|
||
| 1. 현재 저장소를 로컬에 클론(Clone)합니다. | ||
| 2. 자신의 본명으로 브랜치를 생성합니다.(구분 가능하도록 본명을 꼭 파스칼케이스로 표시하세요, git branch KDT0_이름) | ||
| 3. 자신의 본명 브랜치에서 과제를 수행합니다. | ||
| 4. 과제 수행이 완료되면, 자신의 본명 브랜치를 원격 저장소에 푸시(Push)합니다.(main 브랜치에 푸시하지 않도록 꼭 주의하세요, git push origin KDT0_이름) | ||
| 5. 저장소에서 main 브랜치를 대상으로 Pull Request 생성하면, 과제 제출이 완료됩니다!(E.g, main <== KDT0_이름) | ||
| ## 기술 스택 | ||
|
|
||
| + HTML | ||
| + CSS | ||
| + Javascript | ||
| + Jquery | ||
|
|
||
| - main 혹은 다른 사람의 브랜치로 절대 병합하지 않도록 주의하세요! | ||
| - Pull Request에서 보이는 설명을 다른 사람들이 이해하기 쉽도록 꼼꼼하게 작성하세요! | ||
| - Pull Request에서 과제 제출 후 절대 병합(Merge)하지 않도록 주의하세요! | ||
| - 과제 수행 및 제출 과정에서 문제가 발생한 경우, 바로 담당 멘토나 강사에서 얘기하세요! | ||
| ## 구현 내용 | ||
|
|
||
| 필수 요구사항 | ||
| + 시멘틱 태그 사용 | ||
| + CSS만을 이용한 드롭다운 메뉴 | ||
| + 동영상 재생 클릭 시, 연령 확인 후 쿠키 저장 -> 연령 미달 시 동영상 재생 불가 구현 | ||
| + 새소식 반응형을 고려하여 슬라이더로 대체 | ||
| + 마우스를 따라가는 백그라운드 이미지 설정 | ||
| + 비주얼 백그라운드 동영상 재생/정지 버튼 커스텀 | ||
| + 탭 기능 구현 (게임플레이/이야기) | ||
|
|
||
| - 과제에 대한 설명을 포함한 README.md 파일을 제공하세요! | ||
| - 과제 결과와 비교할 수 있는 실제 사이트(페이지)의 주소를 명시하세요! | ||
| - 과정에서 사용한 프로젝트 폴더/파일이 모두 포함돼야 합니다, 일부 파일만 제출하지 마세요! | ||
| - 실제 서비스로 배포하고 접근 가능한 링크를 추가해야 합니다. | ||
| ## 아쉬운 점 | ||
|
|
||
| 선택 요구사항 | ||
| + 반응형을 고려하여 작업 진행했으나, 클론 코딩 사이트를 급하게 변경해 시간 부족으로 반응형 미구현 | ||
| + ~~사이트 로딩에 오래걸림, 최적화 작업 필요~~ 해결(2) | ||
| + 콘솔 오류 확인 필요 | ||
| + 구매하기 모달 창 및 메뉴 버튼 스크롤 js 미구현 | ||
| + swiper.js 사용하면 한 슬라이더에서 두개의 pagination 작동 불가, 다른 슬라이더 대체 또는 해결 방안 연구 필요 | ||
| + ~~크롬 외 모바일 / 맥OS 사파리 등 타 브라우저에서 연령 확인 js가 동작하지 않음~~ 해결(1) | ||
|
|
||
| - < header >, < section > 등 시멘틱 태그를 최대한 활용해보세요. | ||
| - 실제 사이트의 레거시 코드 활용보단 최신의 CSS Flex 혹은 Grid 등을 활용해보세요. | ||
| - 부분적으로 BEM 방법론을 도입해보세요. | ||
| - JS가 필요한 부분은 되도록 생략하되 이유를 명시해보세요.(CSS로 대체 가능한지 피드백이 있을 수 있겠죠?!) | ||
| - JS가 필요한 부분 중 구현할 부분이 있다면 자유롭게 구현해보세요.(JS 과제가 아니니까 가볍게 구현하시길 추천해요) | ||
|
|
||
| 손쉬운 이미지 추출 방법 | ||
| ## 해결 내용 | ||
|
|
||
| 사이트 클론에 필요한 이미지를 좀 더 쉽게 추출하기 위해서 Chrome 확장 프로그램인 Image Downloader를 사용하세요. | ||
| 1. 크롬 외 타 브라우저에서 required 적용되지 않음<br> | ||
| → button onclick으로 연령 인증 스크립트 구현하는 방식을 form action으로 변경 | ||
| 1. 사이트 로딩에 오래걸림, 최적화 작업 필요<br> | ||
| → Img Loading lasy 추가, iframe 탭 활성화 시 src값 입력, window load 후 html fadeIn 효과 | ||
|
|
||
| 1. 원하는 사이트 접속 | ||
| 2. Image Downloader 확장 프로그램 실행 | ||
| 3. 다운로드 원하는 이미지 선택 | ||
| 4. 서브 폴더 이름(Save to subfolder) 명시 | ||
| 5. 다운로드! |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이런 OS가 생성한 파일은 커밋되지 않게
.gitignore에 추가해둬주세요!