-
Notifications
You must be signed in to change notification settings - Fork 0
Y_FE_Toy1_Team11 : YANOLJA TECH SCHOOL 위키 서비스 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
f123648
9472216
b6e979f
867d793
cd3f93a
6f6c94d
6d15e1a
a3f190a
8508e97
90a19ba
1a4869c
450b001
61d8381
ea5cfee
50cb5b0
790bdf9
148a768
b63b9c6
fae0640
d5d478b
234072b
8d6eda1
48f0946
18b439d
dd704de
68b7e0a
8ff925e
8bc274a
d4b92b0
0ad2b21
5eecf9e
8db1ca4
9a549b6
e4acdf9
be9781b
4146f2c
053354f
fcd1110
e870145
0432a12
c7058a4
75f4919
96fb58b
da2f423
fb4e8b1
6aa894a
25bf4d4
6889d15
8f83039
582489d
3937715
5fa0a64
319d857
4790d6a
a1c043e
1cad5a5
645ceab
d20a743
37b3b32
adf6c71
a628906
9b6a88b
feed566
01c2fde
03ef9d3
5788b42
e6e93c2
1fb850b
dbc9177
944f16d
14c5605
cba53cd
dc77f97
ebb9f0b
74f0f5d
a04c442
254005e
5818af4
396bead
29612fe
6cef614
848bdce
afe3c55
d858e17
da6b931
80c0e55
bff5930
f6cd162
bb656bc
88566bb
59657e3
8ad2d48
8ca0e4b
54cd9ba
db62b91
1d1d693
19917d0
210079f
26930d3
8d1997d
1aa2dc5
f0182cc
88fe4e3
1bdccb9
ed2f167
7d1d868
6a2c128
4e82211
5ff2a64
8f958ec
1132672
38de54a
2f7ec85
013aadc
07994d3
dda719e
b5be665
4cc782a
e964a20
f72a422
2bc48ea
604886f
b48cf28
1f873e2
0ac3ca4
aeaa68d
3a108de
bf160e0
059c4fb
73edacc
afd2528
d500b08
a555bc9
9607571
06d1b4d
2c97e45
d346b9a
b806350
c3a2bf7
6375d3e
2e2241a
954288c
5bbf021
ad2fb89
91d0a6e
0a57eb6
b98b20c
57afe9f
d2e093f
6f6d0ae
8bb85ec
c4db4d2
5f28d22
ff365d9
77d2a74
f075680
7ed0e4b
968b0e6
6353199
d93bed8
8628a5c
3bf0f69
c0ad5ba
d6c833f
bbba4db
d4dd60f
e4d343b
47a4a5c
506ad3e
4a54dec
138753a
74e8362
6290708
a8d54c0
7e34a1d
5d1e48b
05169a0
96420a0
f062cd8
0a94297
f7b4713
a978a31
02e6881
1eafcce
9ec1c25
cf56aaf
8f890a6
dead56b
52e50ba
8d86e39
12cf2c9
cfa9624
aa919fe
10f8ebf
7ecc924
e0faeab
c1aa514
4315822
1f91dd1
3d5aabd
fc0cc76
67d5b54
f89167e
0a32b29
376dd68
42f29e8
b0d8778
16ca300
1fe2036
c18aec7
055726a
dfadf7c
fc505b3
7d07c32
399d66e
d521bdc
39dadd3
855b9b8
26457fe
e6f1fab
1486359
51d7074
5f5a5e4
8f03aef
d315c73
894eaad
c1b98d6
27b3dac
6f7cc17
a84013a
47ee4af
f59e270
b8da516
6b2a72a
986dc45
9166df3
1be1e7b
600ed90
247b4b1
f3af143
3c5aa88
f54b7a9
c1aab3d
4d77be3
d57a796
9116a0a
53e7fff
df765c7
20b792a
85467be
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "env": { | ||
| "browser": true, | ||
| "es2021": true | ||
| }, | ||
| "extends": ["airbnb", "airbnb-typescript", "prettier"], | ||
| "parserOptions": { | ||
| "ecmaVersion": "latest", | ||
| "sourceType": "module", | ||
| "project": "./tsconfig.json" | ||
| }, | ||
| "rules": { | ||
| "@typescript-eslint/no-unused-expressions": 0 | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "projects": { | ||
| "default": "techschool-wiki" | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Layout, Wiki, Ranking @[turkey-kim](https://github.com/turkey-kim) | ||
| Layout, Carousel @[jinuk0316](https://github.com/jinuk0316) | ||
| Firestore, Wiki @[JitHoon](https://github.com/JitHoon) | ||
| Firestore, Gallery @[yangjaehyuk](https://github.com/yangjaehyuk) | ||
| Firestore, Timer @[suyeonnnnnnn](https://github.com/suyeonnnnnnn) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| ## 작업내용 | ||
|
|
||
| - 작업 내용을 적어주세요. | ||
| <br> | ||
|
|
||
| ## 주요 변경점 | ||
|
|
||
| - 주요 변경사항에 대해 적어주세요. | ||
| <br> | ||
|
|
||
| ## 유의할 점 (optional) | ||
|
|
||
| - 팀원이 유의해야할 변경 사항이나 로직이 생겼다면 적어주세요. | ||
| <br> | ||
|
|
||
| ## To Reviewers (optional) | ||
|
|
||
| - 리뷰어에게 부탁할 내용(ex.~부분 도움 부탁합니다, ~부분 한 번 더 검토 부탁드려요) 이 있다면 적어주세요. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # This file was auto-generated by the Firebase CLI | ||
| # https://github.com/firebase/firebase-tools | ||
|
|
||
| name: Deploy to Firebase Hosting on merge | ||
| "on": | ||
| push: | ||
| branches: | ||
| - main | ||
| jobs: | ||
| build_and_deploy: | ||
| runs-on: ubuntu-latest | ||
| environment: firebase-deploy | ||
| env: | ||
| REACT_APP_API_KEY: "${{ secrets.REACT_APP_API_KEY }}" | ||
| REACT_APP_AUTH_DOMAIN: "${{ secrets.REACT_APP_AUTH_DOMAIN }}" | ||
| REACT_APP_PROJECTED_ID: "${{ secrets.REACT_APP_PROJECTED_ID }}" | ||
| REACT_APP_STORAGE_BUCKET: "${{ secrets.REACT_APP_STORAGE_BUCKET }}" | ||
| REACT_APP_MESSAGING_SENDER_ID: "${{ secrets.REACT_APP_MESSAGING_SENDER_ID }}" | ||
| REACT_APP_APP_ID: "${{ secrets.REACT_APP_APP_ID }}" | ||
| REACT_APP_MEASUREMENT_ID: "${{ secrets.REACT_APP_MEASUREMENT_ID }}" | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - run: npm ci && npm run build | ||
| - uses: FirebaseExtended/action-hosting-deploy@v0 | ||
| with: | ||
| repoToken: "${{ secrets.GITHUB_TOKEN }}" | ||
| firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_TECHSCHOOL_WIKI }}" | ||
| channelId: live | ||
| projectId: techschool-wiki |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # This file was auto-generated by the Firebase CLI | ||
| # https://github.com/firebase/firebase-tools | ||
|
|
||
| name: Deploy to Firebase Hosting on PR | ||
| "on": pull_request | ||
| jobs: | ||
| build_and_preview: | ||
| if: "${{ github.event.pull_request.head.repo.full_name == github.repository }}" | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| REACT_APP_API_KEY: "${{ secrets.REACT_APP_API_KEY }}" | ||
| REACT_APP_AUTH_DOMAIN: "${{ secrets.REACT_APP_AUTH_DOMAIN }}" | ||
| REACT_APP_PROJECTED_ID: "${{ secrets.REACT_APP_PROJECTED_ID }}" | ||
| REACT_APP_STORAGE_BUCKET: "${{ secrets.REACT_APP_STORAGE_BUCKET }}" | ||
| REACT_APP_MESSAGING_SENDER_ID: "${{ secrets.REACT_APP_MESSAGING_SENDER_ID }}" | ||
| REACT_APP_APP_ID: "${{ secrets.REACT_APP_APP_ID }}" | ||
| REACT_APP_MEASUREMENT_ID: "${{ secrets.REACT_APP_MEASUREMENT_ID }}" | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - run: npm ci && npm run build | ||
| - uses: FirebaseExtended/action-hosting-deploy@v0 | ||
| with: | ||
| repoToken: "${{ secrets.GITHUB_TOKEN }}" | ||
| firebaseServiceAccount: "${{ secrets.FIREBASE_SERVICE_ACCOUNT_TECHSCHOOL_WIKI }}" | ||
| projectId: techschool-wiki | ||
|
Comment on lines
+21
to
+25
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 멘토링 때 말씀드렸듯, 이 영역은 제거되는 게 어떨까 합니다. 개발 환경을 따로 구성하여 그 곳에 배포하거나, 코드 유효성 검사 정도만 진행하는 게 어떨까 합니다.
등을 일반적으로 pull request가 생성됐을 때 진행합니다. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Firestore Hosting 에서 channelId: live를 명시하지 않으면 이를통해 말씀하신 것 처럼 '개발 환경을 따로 구성하여 그 곳에 배포'한 효과를 볼 수 있어서 위 코드를 그대로 사용하였습니다. with: 블럭 안에 channelId: live를 넣어준 firebase-hosting-merge.yml 의 경우,
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @JitHoon |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | ||
|
|
||
| # dependencies | ||
| /node_modules | ||
| /.pnp | ||
| .pnp.js | ||
|
|
||
| # testing | ||
| /coverage | ||
|
|
||
| # production | ||
| /build | ||
|
|
||
| # misc | ||
| .DS_Store | ||
| .env.local | ||
| .env.development.local | ||
| .env.test.local | ||
| .env.production.local | ||
|
|
||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
|
|
||
| # eslint | ||
| .eslintcache | ||
|
|
||
| # firebase | ||
| .firebase | ||
|
|
||
| # env | ||
| .env | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. POSIX 명세 3.206 Line을 확인해보시면, 모든 파일은 개행문자로 끝내도록 정의되어 있습니다. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 헉 전혀 모르고 있었습니다! 다음부터 파일 작성 이후 개행을 하도록 하겠습니다. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #!/usr/bin/env sh | ||
| . "$(dirname -- "$0")/_/husky.sh" | ||
|
|
||
| npx lint-staged |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| README.md |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "arrowParens": "avoid", | ||
| "bracketSpacing": false, | ||
| "endOfLine": "auto", | ||
| "htmlWhitespaceSensitivity": "css", | ||
| "jsxBracketSameLine": false, | ||
| "jsxSingleQuote": false, | ||
| "printWidth": 80, | ||
| "proseWrap": "preserve", | ||
| "quoteProps": "as-needed", | ||
| "semi": true, | ||
| "singleQuote": false, | ||
| "tabWidth": 2, | ||
| "trailingComma": "all", | ||
| "useTabs": false, | ||
| "vueIndentScriptAndStyle": true, | ||
| "requirePragma": false, | ||
| "insertPragma": false | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CODEOWNERS syntax 참고하셔서 문법 수정하셔야할 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CODEOWNERS 사용법을 잘못 이해했던 것 같습니다..!
멘토님께서 주신 syntax 참고하여 수정해 보았습니다.
taki-kim/techschool_wiki@15d6bb6